Use struct tags #2926
Merged
Use struct tags #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
kroening
force-pushed
the
struct-tag
branch
from
83cfc7d to
38a33e7
Compare
kroening
force-pushed
the
struct-tag
branch
from
38a33e7 to
953326b
Compare
kroening
requested review from
chrisr-diffblue and
martin-cs
as code owners
kroening
force-pushed
the
struct-tag
branch
from
953326b to
a21cd68
Compare
tautschnig
approved these changes
Sep 19, 2018
src/ansi-c/c_typecheck_type.cpp
Outdated
| typet tag_type; | ||
|
|
||
| if(type.id() == ID_union || type.id()==ID_incomplete_union) | ||
| tag_type=union_tag_typet(identifier); |
There was a problem hiding this comment.
Nit pick: spacing around = (here and below).
| else if(type.id() == ID_symbol_type) | ||
| else if( | ||
| type.id() == ID_symbol_type || type.id() == ID_struct_tag || | ||
| type.id() == ID_union_tag) |
There was a problem hiding this comment.
Please add braces around the (one-line) body for readability.
tautschnig
assigned
kroening,
martin-cs and
chrisr-diffblue and unassigned
smowton and
tautschnig
allredj
reviewed
Sep 19, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: a21cd68).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85338055
kroening
force-pushed
the
struct-tag
branch
from
a21cd68 to
04c26c4
Compare
allredj
reviewed
Sep 19, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 04c26c4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85349549
|
It should be mentioned that the transition to struct and union tags was a ~5 year project! |
smowton
approved these changes
Sep 20, 2018
chrisr-diffblue
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.